-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated repo collaborators to support ignoring teams #2481
feat: Updated repo collaborators to support ignoring teams #2481
Conversation
1d433f2
to
636bac2
Compare
Signed-off-by: Steve Hipwell <[email protected]>
636bac2
to
5b844f7
Compare
@kfcampbell as this has been approved could you merge it? |
@stevehipwell Apologies for all the delays here and thank you as ever for your contributions. What's going on is that @nickfloyd and I have been pulled into some work for GitHub's broader extensibility future (which is fun! and it's going to be better for GitHub's SDKs in the long term!) but it means 100% of our time right now is being spent on internal projects. This is rough for SDKs support and it makes me feel bad because I want to do better for SDKs like the Terraform provider (you should see my GitHub notifications right now; the badge that counts the number went so high it's broken and simply reads In the meantime, I'll keep trying to do a few PRs and a release every so often. |
Thank you for addressing this. I just made myself a ticket to unlock our provider version and take this for a test drive. Thanks again. |
@kfcampbell could you maybe add what you wrote above to the #1342 discussion? I understand that high level improvements will benefit us in the future but that's not helping us with today and the issue that are currently impacting us. I suspect that most of us non-GitHub contributors are doing this in addition to our actual day jobs and not having our PRs reviewed in a timely manner means we're both losing time on the broken or missing GitHub functionality as well as the time we've spent trying to make it better. With that said I think that #2476 should make your ad-hoc reviewing significantly easier as the whole test suite actually works (locally) and passes (t also gracefully degrades to support the test inputs provided). But to get that merged there are a number of bug fix PRs I've linked in the description that need to be merged first, once these are merged I can rebase the PR and update any changed tests. Once #2476 is merged and the tests can be reliably run locally we could look at #2511 to run the tests in an automated way. |
Too late now, but the docs have the incorrect block name. It lists "team_ignore" but should be "ignore_team" as implemented in the provider. |
This block was added in integrations#2481 but the documentation has the incorrect block name. It's implemented in the provider as ignore_team but the docs referenced "team_ignore". This corrects the documentation to match.
Resolves #2470
Before the change?
github_repository_collaborators
would result in churngithub_repository_collaborators
resource (which works but is technically incorrect).After the change?
github_repository_collaborators
does not churnteam_ignore
block on agithub_repository_collaborators
resource to ignore organization managed teams.ignore_org_teams
resource flag, as that would take multiple API calls and an increase in required permissions.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!